-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump k8s to v0.27.2 #2333
Bump k8s to v0.27.2 #2333
Conversation
@@ -185,7 +185,7 @@ func getNewManagerCache(operatorNamespace string) cache.NewCacheFunc { | |||
labelSelectorForNamespace := labels.Set{hcoutil.KubernetesMetadataName: operatorNamespace}.AsSelector() | |||
return cache.BuilderWithOptions( | |||
cache.Options{ | |||
SelectorsByObject: cache.SelectorsByObject{ | |||
ByObject: map[client.Object]cache.ByObject{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -160,7 +160,7 @@ func add(mgr manager.Manager, r reconcile.Reconciler, ci hcoutil.ClusterInfo) er | |||
|
|||
// Watch for changes to primary resource HyperConverged | |||
err = c.Watch( | |||
&source.Kind{Type: &hcov1beta1.HyperConverged{}}, | |||
source.Kind(mgr.GetCache(), &hcov1beta1.HyperConverged{}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
&source.Kind{Type: resource}, | ||
handler.EnqueueRequestsFromMapFunc(func(a client.Object) []reconcile.Request { | ||
source.Kind(mgr.GetCache(), resource), | ||
handler.EnqueueRequestsFromMapFunc(func(ctx context.Context, a client.Object) []reconcile.Request { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -112,8 +112,9 @@ func (wh *WebhookHandler) Handle(ctx context.Context, req admission.Request) adm | |||
return admission.Allowed("") | |||
} | |||
|
|||
var _ admission.DecoderInjector = &WebhookHandler{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
func InitClient(clientObjects []client.Object) *HcoTestClient { | ||
// Create a fake client to mock API calls | ||
cl := fake.NewClientBuilder(). | ||
WithRuntimeObjects(clientObjects...). | ||
WithObjects(clientObjects...). | ||
WithScheme(GetScheme()). | ||
WithStatusSubresource(clientObjects...). | ||
Build() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Test Coverage Report for Build 5201132516
💛 - Coveralls |
90eedd9
to
4b506ca
Compare
f71d447
to
4ad1102
Compare
hco-e2e-upgrade-prev-index-aws lane succeeded. |
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
hco-e2e-upgrade-index-azure lane succeeded. |
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-aws, ci/prow/hco-e2e-image-index-gcp, ci/prow/hco-e2e-upgrade-index-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
hco-e2e-kv-smoke-gcp lane succeeded. |
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
8e0298a
to
4ea8504
Compare
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-image-index-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Bump k8s to v0.27.2 and sigs.k8s.io/controller-runtime v0.15.0 - github.com/onsi/ginkgo/v2 v2.9.2 => v2.9.5 - github.com/onsi/gomega v1.27.6 => v1.27.7 - github.com/openshift/library-go v0.0.0-20230411150541-a704a5774e20 => v0.0.0-20230516103935-9536341565eb - github.com/operator-framework/api v0.17.3 => v0.17.5 - github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring v0.64.0 => v0.65.1 - github.com/prometheus/client_golang v1.15.0 => v1.15.1 - github.com/prometheus/client_model v0.3.0 => v0.4.0 - golang.org/x/tools v0.8.0 => v0.9.1 - k8s.io/* v0.26.4 => v0.27.2 - k8s.io/kube-openapi v0.0.0-20230327201221-f5883ff37f0c => v0.0.0-20230515203736-54b630e78af5 - sigs.k8s.io/controller-runtime v0.14.6 => v0.15.0 - sigs.k8s.io/controller-tools v0.11.3 => v0.12.0 - github.com/openshift/machine-api-operator v0.2.1-0.20191025120018-fb3724fc7bdf => v0.2.1-0.20230329185430-d3973b45c2b6 - github.com/gorilla/websocket v1.4.2 => v1.5.0 Signed-off-by: stirabos <stirabos@redhat.com>
Kudos, SonarCloud Quality Gate passed!
|
hco-e2e-upgrade-prev-index-sno-aws lane succeeded. |
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
okd-hco-e2e-upgrade-index-aws lane succeeded. |
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-upgrade-index-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
hco-e2e-upgrade-prev-index-aws lane succeeded. |
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp, ci/prow/hco-e2e-upgrade-prev-index-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
okd-hco-e2e-image-index-aws lane succeeded. |
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-image-index-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
hco-e2e-kv-smoke-gcp lane succeeded. |
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure, ci/prow/okd-hco-e2e-image-index-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
hco-e2e-image-index-sno-azure lane succeeded. |
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-sno-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
@tiraboschi: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Great work!!! this one was not simple... hco-e2e-upgrade-index-aws and hco-e2e-upgrade-index-sno-aws lanes passed. /overide ci/prow/hco-e2e-upgrade-index-azure /lgtm |
@nunnatsa: Overrode contexts on behalf of nunnatsa: ci/prow/hco-e2e-upgrade-index-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nunnatsa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override ci/prow/hco-e2e-upgrade-index-azure |
@nunnatsa: Overrode contexts on behalf of nunnatsa: ci/prow/hco-e2e-upgrade-index-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Bump k8s to v0.27.2 and sigs.k8s.io/controller-runtime v0.15.0-beta.0
Reviewer Checklist
Jira Ticket:
Release note: